add ability for plugins to be fetched from authenticated URLs #2896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
requested changes
Oct 25, 2024
Collaborator
rylev
left a comment
rylev
left a comment
There was a problem hiding this comment.
I'd personally prefer this as a CLI option over a header which is way more discoverable.
michelleN
reviewed
Oct 26, 2024
Collaborator
michelleN
left a comment
michelleN
left a comment
There was a problem hiding this comment.
+1 to Ryan's flag suggestion 👍
karthik2804
force-pushed
the
allow_private_plugins
branch
from
8d0bd82 to
7e4e060
Compare
Contributor
Author
|
updated the PR to use a cli flag. |
karthik2804
force-pushed
the
allow_private_plugins
branch
from
7e4e060 to
0904173
Compare
rylev
approved these changes
Oct 28, 2024
itowlson
reviewed
Oct 28, 2024
Collaborator
|
The second commit message says "use cli flag along with env var" but I think it actually removes the env var. Would it be worth rewording the commit message not to imply that the env var is still meant to work? |
Contributor
Author
|
@itowlson I will address the changes and squash the PR with the commit changes as well. |
Signed-off-by: karthik2804 <[email protected]>
karthik2804
force-pushed
the
allow_private_plugins
branch
from
0904173 to
d29ad4c
Compare
Contributor
Author
|
I believe the failing CI is unrelated to the changes here. |
itowlson
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables users to set a
SPIN_PLUGIN_AUTH_HEADERenvironment variable that will then be set on the outgoing request. For example, the header would have a value liketoken <gh_token>to get a plugin from a private repo.If this would be better served as a flag like `spin plugins install <secret_plugin> --auth-header "token <gh_token>", I would be happy to update this PR.